Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity: Upgrade evmone from 0.4.0 to v0.8.0 #6207

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

bshastry
Copy link
Contributor

Should fix failing build as well.

@DavidKorczynski DavidKorczynski enabled auto-merge (squash) August 12, 2021 08:37
@bshastry
Copy link
Contributor Author

I'm not sure where the error leading up to building failure is coming from

/usr/local/bin/llvm-ar: error: script line 1: unknown command: OPEN

perhaps it has something to do with a recent update to ossfuzz compiler toolchain builder pack?

@jonathanmetzman
Copy link
Contributor

Can confirm there was a toolchain roll on Aug 11 https://chromium.googlesource.com/chromium/src/+/ce8f94ef957739b440ea78875bf3d2ea0382003d

@jonathanmetzman
Copy link
Contributor

jonathanmetzman commented Aug 13, 2021

Can confirm there was a toolchain roll on Aug 11 https://chromium.googlesource.com/chromium/src/+/ce8f94ef957739b440ea78875bf3d2ea0382003d

However, solidity's build started failing with same issue on August 10 so not sure this is related: https://oss-fuzz-build-logs.storage.googleapis.com/log-70ac0797-dd9c-4ebd-8dbc-10311c0dfb62.txt

Can you replace the from line in dockerfile to FROM gcr.io/oss-fuzz-base/base-builder@sha256:a752ca08bc5b2b3cc1354ca50f09c46211dd52663d295fd09023a431237dd2b8 so we can try building with old toolchain?

auto-merge was automatically disabled August 23, 2021 08:39

Head branch was pushed to by a user without write access

@bshastry
Copy link
Contributor Author

Can you replace the from line in dockerfile to FROM gcr.io/oss-fuzz-base/base-builder@sha256:a752ca08bc5b2b3cc1354ca50f09c46211dd52663d295fd09023a431237dd2b8 so we can try building with old toolchain?

Just pushed the commit with this change.

@jonathanmetzman
Copy link
Contributor

OK. Please undo. Looks like this isn't a toolchain issue.

@bshastry
Copy link
Contributor Author

OK. Please undo. Looks like this isn't a toolchain issue.

It looks like a build issue in a dependency. Have created an issue to track it: ethereum/evmone#373

@bshastry bshastry force-pushed the fix-solidity-build branch from eef15f9 to 6d8a752 Compare August 26, 2021 11:11
@asraa asraa merged commit b3630ab into google:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants